On Tue, 29 Oct 2002 13:23:22 +0000
Keith Whitwell <[EMAIL PROTECTED]> wrote:

> Felix,
> 
> I've cleaned up the WaitForFrameCompletion function a bit & committed.  The
> logic is slightly different, but a lot easier to read/understand, I think.

Ok, I just think that the name rmesa->irqsEmitted is now a bit
misleading (can't think of a better one, though). And you removed the
delay loop. I remember reading a comment like "don't hammer the bus" in
the old code. And by removing the delay loop you also eliminated the
cause for the IRQ/busy ping ponging. So the irqsEmitted magic should be
no longer necessary.

Finally, if do_irqs is disabled you alsways use usleeps. But I assume
it's your intention to never do real busy waiting.

Felix

               __\|/__    ___     ___     ___
__Tschüß_______\_6 6_/___/__ \___/__ \___/___\___You can do anything,___
_____Felix_______\Ä/\ \_____\ \_____\ \______U___just not everything____
  [EMAIL PROTECTED]    >o<__/   \___/   \___/        at the same time!


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to