Felix Kühling wrote:
Hi,

while I was trying to understand the vtxfmt mesa code and poking around
with gdb I noticed that the neutral vtxfmt wrapper gets restored quite
often. I tracked it to radeonFlushVertices where
_mesa_install_exec_vtxfmt( ctx, &rmesa->vb.vtxfmt ) is called if the
FLUSH_UPDATE_CURRENT flag is set. _mesa_install_exec_vtxfmt in turn sets
ctx->TnlModule.Current to the new exec vertex format and calls
_mesa_restore_exec_vtxfmt( ctx ) which restores the neutral wrapper. Is
this really what was intended here?

The only place I could find where the FLUSH_UPDATE_CURRENT flag is set
in the radeon driver is in radeon_vtxfmt_c.c and there the Exec dispatch
table is modified directly. So there should be no need for reinstalling
the vertex format.
It is necessary to do that there. I can't bring an example off the top of my head, but feel free to remove the call & play with the mesa demos. Something should break before too long...

I guess I should have left a comment there to explain/remind myself why.

Keith




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to