On 01 Jul 2003 at 01h13, Michel Dänzer wrote: Hi,
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,1) > > +#include <linux/wrapper.h> > > +#endif > > What's this for? The linux/wrapper.h header seems to have been around > since 2.2 at least. It isn't there anymore :) > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,1) > These version comparisons aren't correct, the interrupt handling code > was only changed very recently, around 2.5.70 IIRC. > > Also, you always return IRQ_HANDLED, even if you weren't interested in > the interrupt at all and didn't do anything about it. You should move > the return IRQ_HANDLED into the if block and return IRQ_NONE at the end > of the function (and drop the superfluous return for older kernels). Ok, i'll fix these and send a second patch as soon as anoncvs will have caught up. Thanks for pointing this! -- Colin http://colino.net/323/ - Presenting the Mazda 323 Rouge ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
