On Mon, 2003-07-14 at 16:59, Alex Deucher wrote:
> --- Michel D&#228;nzer <[EMAIL PROTECTED]> wrote:
> > On Mon, 2003-07-14 at 02:59, Alex Deucher wrote:
> > > --- Michel Dnzer <[EMAIL PROTECTED]> wrote:
> > > > On Mon, 2003-07-14 at 00:34, Alex Deucher wrote:
> > > > 
> > > > > however, the framebuffer on crtc1 is still shifted a few pixels
> > to 
> > > > > the left when you run an opengl app in clone mode.  side by
> > side 
> > > > > modes work fine.  everything works fine with pageflipping
> > disabled.
> > > > 
> > > > Hmm, for a second I thought I had botched the RADEON_CRTC_OFFSET
> > > > calculation in the DRM as well, but it looks to me like it should
> > be
> > > > identical to that in RADEONDoAdjustFrame(). Agreed?
> > > 
> > > I would think so.  Should the patch [...]
> > 
> > I forgot to unattach the patch, it's clearly wrong (if it was
> > correct,
> > the error would have been significant and on the y axis). Do you
> > agree
> > that in RADEONDoAdjustFrame() and radeon_cp_dispatch_flip() the same
> > value gets written to RADEON_CRTC_OFFSET for the same frame position?
> > (Note that pitch = displayWidth * <bytes per pixel>)
> 
> no. the order of operations are different.  RADEONDoAdjustFrame()
> multiplies _all_ of base by 2, 3, or 4 while radeon_cp_dispatch_flip()
> only multipies x by the color_fmt.

You didn't read my notes in parentheses. ;) In addition to the one about
the y axis above, I wrote:

> > (Note that pitch = displayWidth * <bytes per pixel>)

and <bytes per pixel> = color_fmt-2 .


-- 
Earthling Michel Dänzer   \  Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast  \     http://svcs.affero.net/rm.php?r=daenzer



-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to