On Fri, 2003-08-08 at 22:40, Ian Romanick wrote: > Michel Dänzer wrote: > > On Thu, 2003-08-07 at 21:57, Ian Romanick wrote: > >>Michel Dänzer wrote: > >>>On Tue, 2003-08-05 at 18:52, Ian Romanick wrote: > >>> > >>>>Michel, does that INREG work for PCIGART as well? > >>> > >>>No, good point, you need > >>> > >>>INREG( RADEON_AIC_LO_ADDR ) + dri_priv->agpTexOffset > >>> > >>>for that. > >> > >>Okay, that would be easy enough to add later. Right now neither driver > >>supports PCIGART texturing. It probably should be added at some point. > > > > Indeed, I've been working a bit on removing the artificial PCI GART > > limitations, I hope to post something soon, I won't have much time over > > the weekend though. > > Cool. I'll be looking forward to that. :) > > In reference to your question on IRC about that r128 driver, it would > probably work to make similar changes to that driver. However, I don't > think there's much point. Every existing card uses the same value, and > I can't invision ATI making a new 64MB or 128MB version of that chip. :)
True. :) The memory layout is also hardcoded in this value, but there's probably less incentive to ever change that in the r128 driver as well. > >>I have modified the R200 driver to use the same technique to get > >>agp_texture_offset. The required the use of a couple radeon_*.h header > >>files. I hope that's okay. > > > > It was a matter of time. :) This patch looks great to me. > > I decided that it was easier to do that than add duplicate of the INREG > macro and RADEON_MC_AGP_LOCATION contant in the r200 specific header > files. IMHO, we'd be better of the just have the r200 specific > registers, etc. in r200_reg.h and have the common ones in radeon_reg.h. Absolutely. > That would remove some of the textual differences (i.e., that diff > shows) between the two drivers. Alas, it would take a lot of effort to > change at this point with very little to gain. I'm not sure I agree. The gain may be little right now, but it might prevent further duplication and inconsistencies between the drivers, which might prove to be a big gain in the future. I'm aware though that these are many 'may's and 'might's. :\ -- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
