John,

i gave your code a short review and found nothing worth a note.
In other words, if there is a problem at all 
then i've overlooked that due to the speed i browsed it.

One thing to ask you: there is always those secondary PCI ID
on the current Radeon designs. Do you see some chance to get
rid of irritating logfile messages that concern those 2nd ID.

I currently do think of this operation for DRM(probe):

  return 0 => device not supported by this driver
  return 1 => device is supported by this driver
  return 2 => device is not useable and must be 
              forecfully ignored in probing.

What do you think?

-Alex.

> -----Original Message-----
> From: Jon Smirl [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, October 15, 2003 19:12
> To: dri-devel
> Subject: Re: [Dri-devel] Adding hardware detection to DRI drivers
> 
> 
> The attached patch adds a new DRM IOCTL: 
> DRM_IOCTL_GET_SUGGESTED_UNIQUE. It
> works by hooking into the OS PCI device detection at module 
> load time. Each DRM
> driver now contains the PCI IDs of all the cards that it 
> supports. The OS then
> matches these to the hardware in the system.  Current Xfree 
> binaries will work
> unmodifed with this change.
> 
> The new call is needed to support standalone Mesa. Standalone 
> Mesa does not
> have the PCI probing code that is in Xfree. I'm also trying 
> to make config
> files an option for standalone Mesa.
> 
> To use it:
> open the DRM device
> IOCTL: DRM_IOCTL_GET_SUGGESTED_UNIQUE.
> IOCTL: DRM_IOCTL_SET_UNIQUE
> 
> If you are familar with the hardware please check that I got 
> the PCI ID lists
> right.
> 
> The patch is against kernel 2.6.0-test7. I've been told that 
> the same code
> should would with BSD but I don't run it.
> 
> 
> 
> =====
> Jon Smirl
> [EMAIL PROTECTED]
> 
> __________________________________
> Do you Yahoo!?
> The New Yahoo! Shopping - with improved product search
> http://shopping.yahoo.com
> 


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to