On Tue, 2003-11-18 at 18:55, Dave Jones wrote: > On Fri, Oct 31, 2003 at 11:46:54AM -0800, James Jones wrote: > > test8 had broken detection for this agp chipset. You have to edit a > > file in the x86_64 arch directory to get it to allow more than 0 > > (assuming you configed for uniprocessor) bridges to be used, as it > > checks a variable after incrementing rather than before. I also found > > the check wasn't even getting compiled in as the CONFIG_ define had a > > different name in the arch file than in amd64-agp.c, and only one of > > these matched the actual config define name. > > > > Haven't tried test9 yet, I sent a patch to dave jones after I noticed > > this in test7, but I received no response. > > I don't recall seeing this mail. Bounce me another copy?
Don't know about the CONFIG_ define problem on x86-64, but this fixes it for x86. -- Ronny V. Vindenes <[EMAIL PROTECTED]>
--- linux-2.6.0-test8/drivers/char/agp/amd64-agp.c.orig 2003-11-18 22:09:13.000000000 +0100 +++ linux-2.6.0-test8/drivers/char/agp/amd64-agp.c 2003-11-18 22:14:23.000000000 +0100 @@ -355,12 +355,12 @@ #endif return -1; } - hammers[i++] = loop_dev; - nr_garts = i; if (i == MAX_HAMMER_GARTS) { printk(KERN_INFO PFX "Too many northbridges for AGP\n"); return -1; } + hammers[i++] = loop_dev; + nr_garts = i; } return i == 0 ? -1 : 0; }