On Thu, 2004-01-01 at 13:10, Arjan van de Ven wrote: > On Thu, 2004-01-01 at 13:03, Michel DÃnzer wrote: > > > How does this patch look? > > ugly. > > I find using #defines for function arguments ugly beyond belief and > makes it really hard to look through code. I 10x rather have an ifdef in > the function prototype (which then for the mainstream kernel drm can be > removed for non-matching versions) than such obfuscation.
That doesn't strike me as particularly beautiful either... is it really easier for merges, considering that the ugly way is kinda needed for functions which take different arguments on BSD anyway? -- Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer Software libre enthusiast | http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
