On Tue, 2004-06-01 at 16:40, Ian Romanick wrote: > Nothing appears to call drmGetBufInfo. The drmBufInfo and drmBufDesc > structures aren't used anywhere except in that function. The problem is > (surprise!) the definition for drmBufDesc is different in drm.h from > what's in xf86drm.h. This is only a problem because drmBufInfo has a > pointer to an array of structures, and libdrm.a is dynamically linked > with the X server. So, if any DDX driver were to use that function, and > the size of the structure changed, there'd be a problem. > > BUT nothing uses it. Since it's broken, I'd like to remove all traces > of it (from both user mode and kernel mode). Is there any reason not > to? If we need that functionality later, we can design a better > interface for it that will less fragile.
Here's my vote for the axe. I've never seen drmstat.c used. -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] ------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X. >From Windows to Linux, servers to mobile, InstallShield X is the one installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
