DRM_IOCTL_ARGS, DRM_ERR, DRM_CURRENTPID, DRM_UDELAY, DRM_READMEMORYBARRIER, DRM_COPY_FROM_USER_IOCTL etc etc existed prior to freebsd support? Oh my god...
Heh. I actually find those ones pretty innocuous and easy to work with, compared to some of the stuff in there. Nothing that etags can't disambiguate for you.
What's more challenging is are the macros defined in the drivers which then customize the behaviour of shared header files - these are really the challenging aspect to working with that code, and what Dave has been working to remove.
I'm currently open for constructive critics with ideas on how to fix these things, the DRM is open for business if we can fix things up now it will be a lot easier while I'm knee deep with time than after I'm finished and back travelling .. should we have try to implement Linux fns in BSD, what do we do if more parameters/info are needed from a BSD side, or do we try and sideline all these into a separate library of functions and wrap them on both bsd and linux?
Dave's hit the nail on the head here. If you'd like some changes, feel free to make suggestions.
The macros you outline aren't great, but they aren't the real impediment to working with/understanding drm either. But if we can fix that stuff up at the same time, why not?
Keith
------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
