On Fri, Aug 20, 2004 at 07:48:44PM +0100, Keith Whitwell wrote:
> Sam Ravnborg wrote:
> >On Thu, Aug 19, 2004 at 03:26:07PM -0700, Erdi Chen wrote:
> >
> >>This patch adds two new ioctl's to the VIA Unichrome/Pro DRM driver:
> >> DRM_IOCTL_VIA_DMA_INIT
> >> DRM_IOCTL_VIA_CMDBUFFER
> >>
> >>The first call sets up an area in AGP memory that will be used as the
> >>ring buffer. The second call copies a command buffer from user space
> >>memory to the ring buffer.
> >
> >
> >A few comments to the coding style - nothing to the functionality.
> >[inlining your patch would make it soo much easier to review and comment]
> >
> >1) Defines are mixed casisng. Usual style is upper case only except if
> >casing match definitions in datasheet.
>
> I have no problem at all with the use of mixed case in register defines.
> This file looks like it is a drop from a third party and was probably
> autogenerated from a register database. I'd prefer not to subject it to
> hand-reformatting.
Agree with you here. Copied from a third party is as valid as copied from
a data sheet.
I expect the third-party allow such copying..
Sam
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
