-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Tuesday 24 August 2004 18:01, Ronny V. Vindenes wrote:
tir, 24,.08.2004 kl. 13.40 -0700, skrev Ian Romanick:
Ronny V. Vindenes wrote: Of course, once we get to that point, I think we should get the existing TCL paths and run everything as a vertex program. I guess we can cross (and debate) that bridge when we come to it...
I agree, my concern was that particularly games test for certain extensions then pick a suitable code path, either because it's theoretically faster or because it allows more/better eye-candy, under the assumption that any supported extension is fully accelerated. I don't know if GL_ARB_vertex_program is actually used like that, it just happened to make me think (out loud).
I've now briefly tested Philipp's patches on x86-64; didn't see anything break and the GL_ARB_vertex_program tests in progs/{demos,tests} all seemed to work.
NV_vertex_program however...
The codegen version of NV_vertex_program is busted. The body of the C representation refers to a 'param' variable, but the function doesn't have any argument named 'param', but instead local_param and env_param. The real fun is that we don't handle an error from tcc at all correctly, so rather than falling back to interpreted vertex programs we just segfault.
Attached patch is the "obvious" fix, but it's still wrong, fplight and fptest1 render wrong, though they at least run. Perhaps UREG_TYPE_PARAM means env_param instead of local_param... Also I'm pretty sure the UREG_TYPE_ENV_CONST case is wrong, since we never declare an env_const variable in the generated C.
I've checked in your work-around. Maybe if I find some time I'll dig a bit deeper into the problem.
-Brian
------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
