yeah we'll need to implement a msleep_interruptible in drm_compat.h if we
are running on a kernel which doesn't have it ...
drm_os_linux.h also has a schedule_timeout, that i830_wait_irq function
looks a bit bogus to me .. not sure it shouldnt look like some of the
others...
Dave.
On Sat, 18 Sep 2004, Jon Smirl wrote:
> Dave, what do you want to do about this one, inline function?
> msleep_interuptible is only available on recent kernels.
>
>
> On Thu, 16 Sep 2004 09:43:49 -0700, Nishanth Aravamudan <[EMAIL PROTECTED]> wrote:
> > Any comments would be appreciated.
> >
> > Description: Use msleep_interruptible() instead of schedule_timeout() to
> > guarantee the task delays as expected.
> >
> > Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
> >
> > --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/i830_irq.c 2004-09-09
> > 23:05:37.000000000 -0700
> > +++ 2.6.9-rc1-mm4/drivers/char/drm/i830_irq.c 2004-09-10 10:34:30.000000000 -0700
> > @@ -105,7 +105,7 @@ int i830_wait_irq(drm_device_t *dev, int
> > ret = -EBUSY; /* Lockup? Missed irq? */
> > break;
> > }
> > - schedule_timeout(HZ*3);
> > + msleep_interruptible(3000);
> > if (signal_pending(current)) {
> > ret = -EINTR;
> > break;
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
> > Project Admins to receive an Apple iPod Mini FREE for your judgement on
> > who ports your project to Linux PPC the best. Sponsored by IBM.
> > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
> > --
> > _______________________________________________
> > Dri-devel mailing list
> > [EMAIL PROTECTED]
> > https://lists.sourceforge.net/lists/listinfo/dri-devel
> >
>
>
>
>
--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
