Hi,

1-bit fields should be unsigned (i.e., no sign bit).
Sparse also complains about them, as in:
drivers/char/drm/sis_ds.h:88:12: warning: dubious one-bit signed bitfield
drivers/char/drm/sis_ds.h:89:16: warning: dubious one-bit signed bitfield

Is current linux-2.6.9-bk tree anything close to DRM CVS?
Maybe this has already been fixed...

Thanks,
--
~Randy
Make 1-bit fields be unsigned (no sign bit :).
sparse complains about them:
drivers/char/drm/sis_ds.h:88:12: warning: dubious one-bit signed bitfield
drivers/char/drm/sis_ds.h:89:16: warning: dubious one-bit signed bitfield

Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>

diffstat:=
 drivers/char/drm/sis_ds.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./drivers/char/drm/sis_ds.h~sis_bits ./drivers/char/drm/sis_ds.h
--- ./drivers/char/drm/sis_ds.h~sis_bits	2004-08-13 22:36:57.000000000 -0700
+++ ./drivers/char/drm/sis_ds.h	2004-10-11 07:59:31.861263400 -0700
@@ -85,8 +85,8 @@ struct mem_block_t {
 	struct mem_block_t *heap;
 	int ofs,size;
 	int align;
-	int free:1;
-	int reserved:1;
+	unsigned int free:1;
+	unsigned int reserved:1;
 };
 typedef struct mem_block_t TMemBlock;
 typedef struct mem_block_t *PMemBlock;

Reply via email to