On Maw, 2004-11-30 at 20:09, Thomas HellstrÃm wrote:
> Textures in AGP memory is currently not allowed, but they are disabled 
> in the Mesa driver as well, for some reason. If they are allowed in the 
> future, Texture address checks probably have to be implemented but that 
> should be a minor task.

I certainly turned them off because they were crashing my box in the
original "hey it sort of works" codebase. I don't know if its that or if
someone did more work on it later. 

> The verifier is reasonably fast. It lowers the glxgears frame-rate a 
> percent or two. However if it operates directly on AGP memory, it's a 
> _real_ performance killer. So the userspace command buffer should be 
> copied to kernel (static) system memory, checked and then copied again 
> to the AGP ring-buffer.

That should be fine if the command buffers are not too large (< 64K or
so) because they will be cached for the two passes.

> Not all 3D functionality is in, but it is a start and it apparently 
> works ok with the current Mesa unichrome driver. I've tested glxgears, 
> chromium, tuxracer and the GL xscreensavers.

I'd rather it under than overpermitted things too.

> Comments are appreciated, particularly on the security assumptions and 
> whether something doesn't fit well into the DRM coding style.

Only real comment is that it would be better if the tables were
pre-initialized. gcc has some extensions for just specifying bits of an
array that might do this. Thats really it.

Looks good



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to