Alan Cox wrote:
This in itself is a little bit strange since, if the following occurs:* Check condition * if false, go to sleep and DRM_WAKEUP is called by the interrupt handler in between those two, the sleep should never occur, which now it seems to do anyway.Is the current code still using the deprecated sleep_on type functions ? #define DRM_WAIT_ON( ret, queue, timeout, condition ) \ do { \ long __ret; \ __ret = wait_event_interruptible_timeout(queue, condition, timeout); \ if (__ret == 0) \ ret = -EBUSY; \ else if (__ret == -ERESTARTSYS) \ ret = -EINTR; \ } while (0) ^^^^^ New implementation ^^^^^ #define DRM_WAKEUP( queue ) wake_up_interruptible( queue ) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel |
- Re: DRM_WAIT_ON changed behaviour. Thomas Hellström
- Re: DRM_WAIT_ON changed behaviour. Dave Airlie
- Re: DRM_WAIT_ON changed behaviour. Nishanth Aravamudan
- Re: DRM_WAIT_ON changed behaviour. Dave Airlie
- Re: DRM_WAIT_ON changed behaviour. Thomas Hellström