Dave Airlie wrote:
I agree, patch should be reverted. The difference between my change and
the previous code, fundamentally, is that mine slept as long as possible
relative to the passed in timeout until either a signal or wait-queue
event happened; the original code, in contrast, slept for a fixed amount
of time (10 ms or 1 jiffy, whichever is longer) up to a specified total
time.
Okay I reverted it...
Dave.
Thanks,
/Thomas
You can revert drm_os_linux.h to version 1.30 and see if it still works
fine..
Alan, The old code uses schedule_timeout and signal_pending along with a
waitqueue, I don't think it has been deprecated in anyway.. as in what is
in the kernel is what I consider the current code and Christoph hasn't
complained :-)
The old code is fine -- I just was trying to consolidate the users of HZ
in to one place.
Thanks,
Nish
|
