On 6/11/05, Adam Jackson <[EMAIL PROTECTED]> wrote: > > I did it so that maintenance of the flags would be in a single place. > > All of those flags are exactly duplicated in radeonfb. If I recall > > right I'm the one who added the flag code to DRM to begin with and I > > copied it out of radeonfb. The flags were a quick way to demonstrate > > that radeon drm/fb could share data and routines. > > This doesn't really answer why radeonfb _needs_ those flags. Since you just > added those inlines, they can't have been getting called before.
radeonfb has always had the flags the same as DRM. The flags are duplicated in both drivers which makes a maintenance issue. When making radeon depend on radeonfb all of the common code has to exist in radeonfb. That's because radeonfb can still be used standalone. This does bring up an issue. One of the points of doing this is to eliminate duplicated code between radeon and radeonfb. Since radeonfb has to run standalone the duplicated code will be removed from radeon. BSD doesn't have a parallel for radeonfb so replacements for the removed code will need to be made in BSD specific files. Doing that shouldn't be too hard, we already have the code it's just being removed from shared and made BSD specific. > > There are two radeonfb drivers in the Linux tree. There is an old one > > that should be removed in drivers/video. The real one is in > > drivers/video/aty. The patch was generated against the one in > > drivers/video/aty. > > That's certainly nonintuitive. The diff clearly had the path to drivers/video/aty, not drivers/video. The old radeonfb driver is still in the tree for people who have trouble with the fancy power management code in the new radeonfb. It still has a few bugs but most are gone, the parallel drivers have been there for almost two years. Sooner or later BenH will remove the old one and force everyone onto the new one to shake out the final bugs. -- Jon Smirl [EMAIL PROTECTED] ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
