On Tuesday 21 June 2005 21:15, Rune Petersen wrote:
> Aapo Tahkola wrote:
> *snip*
> > + if (info->ChipFamily >= CHIP_FAMILY_R300) {
> > + unsigned char *RADEONMMIO = info->MMIO;
> > + OUTREG(0x180, INREG(0x180) | 0x1100);
> > + }
> > +
> 0x180 is defined as R300_MC_INIT_MISC_LAT_TIME in r300_reg.h.
> This seams unrelated to tiling. I agree that a) the appropriate #defines should be added in the 2D driver instead of putting magic values everywhere when we can do better and b) this should be split out into a different patch (note that you can do this kind of splitting with a simple editor; you just have to make sure that you do not modify the patch chunks themselves, be especially with the whitespace) > Also I remember seeing that the values > are different depending on chip family. Is this safe? Well, I have tested this on three different chips (R300, rv350 (mobile) and R420, which is quite a nice sample), and: - fglrx sets this on all the chips and - setting it in our driver caused no regressions. Of course, it would be even better if people could test it on their hardware (use hw_script from r300 CVS to query the register value while fglrx is running, as well as test the patch). cu, Nicolai
pgp66TLxvo7vs.pgp
Description: PGP signature
