On 6/26/05, Eric Anholt <[EMAIL PROTECTED]> wrote:
> Are you saying this:
> if ((offset>=dev_priv->fb_location) &&
> (offset<dev_priv->gart_vm_start)) return 0;
> is more readable than:
> if ((offset >= dev_priv->fb_location) &&
> (offset < dev_priv->gart_vm_start))
> return 0;
Lindent would do this even with the wrap set at 80 columns.
if ((offset>=dev_priv->fb_location) && (offset<dev_priv->gart_vm_start))
return 0;
This is from the DRM code formatted with an 80 column limit. Lindent
will let strings exceed 80 columns. To me it look like 13 lines of
code turned into 28.
/* If permanent maps are implemented, maps must match */
if (dev->driver->permanent_maps) {
DRM_DEBUG
("Looking for: offset = 0x%08lx, size =
0x%08lx, type = %d\n",
map->offset, map->size, map->type);
list_for_each(_list, &dev->maplist->head) {
drm_map_list_t *_entry =
list_entry(_list, drm_map_list_t,
head);
DRM_DEBUG
("Checking: offset = 0x%08lx, size
= 0x%08lx, type = %d\n",
_entry->map->offset,
_entry->map->size,
_entry->map->type);
if (_entry->map
&& map->type == _entry->map->type
&& map->offset ==
_entry->map->offset) {
_entry->map->size = map->size;
drm_free(map, sizeof(*map),
DRM_MEM_MAPS);
map = _entry->map;
DRM_DEBUG
("Found existing: offset =
0x%08lx, size = 0x%08lx, type = %d\n",
map->offset, map->size,
map->type);
goto found_it;
}
}
--
Jon Smirl
[EMAIL PROTECTED]
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
