On Jul 13, 05 09:16:32 -0600, Brian Paul wrote: > >find a patch attached that fixes all remaining strict-aliasing problems > >when compiling Mesa with gcc 4 (at least for me). > > Are you sure you've got the #ifdef logic correct?
I just copied the one that was already present and didn't think much about it. > #if defined(GLX_VERSION_1_1) && defined(GLX_SGIX_fbconfig) > typedef void *fbc_t; > #else > typedef GLXFBConfigSGIX fbc_t; > #endif > > I would expect that the proper test would be: > > #if defined(GLX_SGIX_fbconfig) > typedef GLXFBConfigSGIX fbc_t; > #else > typedef void *fbc_t; > #endif I would expect that as well. But I wanted a minimal invasive change. Feel free to change this ;) > > I'd probably also replace 'fbc_t' with 'fbconfig_t' to make it more > readable. That's perfectly fine for me. Thanks Matthias -- Matthias Hopf <[EMAIL PROTECTED]> __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ [EMAIL PROTECTED] Phone +49-911-74053-715 __) |_| __) |__ labs www.mshopf.de ------------------------------------------------------- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
