I reviewed the cleanup done by Olliver McFadden and had the following questions:
-int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) +static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int prim) Is it necessary/usefull that the function is static? -/* Immediate implementation has been removed from CVS. */ - -/* vertex buffer implementation */ - -static void inline fire_EB(r300ContextPtr rmesa, unsigned long addr +static void inline r300FireEB(r300ContextPtr rmesa, unsigned long addr Why move all the comments to the head of the file. IMO the method should have a doxygen comment that states it is the vertex buffer implementation of fire_EB, right? - if (num_verts > 65535) { /* not implemented yet */ + if (num_verts > 65535) { Comments like this should be kept. Otherwise it looks like a hardware limitation while the limitation can be worked around or the limitation does not exist. Last but not least is r300_foo_bar preferred or r300FooBar Which is the one mesa uses? Otherwise thumbs up for starting to cleanup code... on of the most unthankfull jobs :-) Regards, Christoph Brill ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel