-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Michel Dänzer wrote: > On Mon, 2007-06-11 at 15:20 -0700, Jesse Barnes wrote: >> On Monday, June 11, 2007 11:36:10 Keith Packard wrote: >>> ick. just read the registers and return the value here. We should place >>> wrap-detection in the core code by reporting the range of the register >>> values; with the offset suggested above, that would result in a single >>> addition to convert from raw to cooked frame counts. >> Ok, here's an updated version: >> - move wraparound logic to the core >> - add pre/post modeset ioctls (per-driver right now, making them core would >> mean lots more DDX changes I think), > > Shouldn't really matter, DDX drivers can call driver independent ioctls. > >> hope I got this right >> - add vblank_get/put calls so interrupts are enabled at the right time >> >> I haven't implemented Ville's suggestion of adding a short timer before >> disabling interrupts again, but it should be easy now that the get/put >> routines are in place and we think it's worth it (might make vblank >> calls a little cheaper, but it would probably be hard to detect). > > Yeah, I'm doubtful. Ville, can you explain some use cases you're > thinking of?
If an app is running with swap buffers synchronized to vblank, won't it go through the following: - - Render scene. - - Start to wait for vblank. - - Enable vblank int. - - Wait. - - Disable vblank int. - - Do swap. - - Repeat. Isn't there some cost associated with the extra enable / disable of the vblank interrupt? In addition, the "fake" wall clock based vblank counter might have accuracy problems with periods of only one or two vblanks. Unfortunately, these are the cases where apps will care the most about accuracy. My guess is that only some drivers, most likely those that lack a hardware vblank counter, will care about the disable delay timer. Perhaps this could be added later...when the need actually arises? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGbrNZX1gOwKyEAw8RAoMtAJ98JrYEVtMNXremOJ0tjUeL+fEyuQCeJraF w3NxVjD7vcdymP8aRgS98lI= =mnG1 -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
