On Mon, 2007-12-17 at 21:07 +0000, Keith Whitwell wrote: > Keith Packard wrote: > > Here are some proposed cleanups and documentation for the drm_ttm.c APIs. > > > > One thing I didn't change was the name of drm_ttm_fixup_caching, which is > > clearly a badly named function. Can anyone explain why you wouldn't just > > always use drm_ttm_unbind instead? The only difference is that > > drm_ttm_unbind makes sure the object is evicted before flushing caches > > and marking it as unbound. > > Looks good Keith. There are a couple of places where you need > s/flat/flag otherwise looking great.
heh. thanks for the spelling fixes. > I can't help with the question above unfortunately... Yeah, I'll leave it alone for now. If we can sort out that and the whole ttm_bo_handle_validate -> ttm_bo_do_validate -> ttm_buffer_object_validate chain, I'd feel better about that part of the code. Now I'm puzzling through the fence portions, and trying to figure out why the flushing code is so mystic. -- [EMAIL PROTECTED]
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
