On Fri, Aug 1, 2008 at 8:13 PM, Keith Packard <[EMAIL PROTECTED]> wrote: > On Fri, 2008-08-01 at 18:48 +0200, Jakob Bornecrantz wrote: > >> The basic fault here is that you have added a driver specific flag to a >> generic >> ioctl/syscall. Which the last time I checked we didn't want. For example on >> PCIE Radeon there is no GTT to map, so bit 31 makes no sense there. > > The GEM MMAP ioctl is driver-specific, not generic for precisely this > reason.
If you want a none generic ioctl for that function go ahead, but IHMO it should then be some sort of flag field on the request. Fiddling with bits on the address feels a bit icky at best. But, the last time I check the only reason you could even hope to get a mmap ioctl into mainline was under the provision that you later moved it to the mmap syscall, which is however generic. Cheers Jakob. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
