Jesse Barnes wrote: > > Anyway, to me this discussion is more of a "future directions" one than > a blocker for this particular patchset. AFAICT the only thing that > needs fixing with this patch is my lock confusion (struct_mutex vs > mode_config). Or would you like something substantial changed with > these bits before they land? > > I think as long as there are efficient ways to short-circuit this implementation if the command submission mechanism does a better job, I think it's OK. I had a quick look in the new dri2 code and it looks like the driver can trick dri2 into thinking there are no outstanding swaps, thus avoiding the event reads? What's important is that the IOCTL interface gets right.
What remains to be fixed are the mutex issue and possibly the poll issue. I also think without looking to closely that the drm_read() function doesn't do return values properly (see ldd3 and man 2 read for return values for the various blocking modes). In particular, wait_event_interruptible() may return -ERESTARTSYS which should never be returned to user-space. It also looks like the new ioctl argument lengths are not 64 bit aligned? /Thomas ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
