On Thu, Nov 12, 2009 at 11:17:58AM -0800, Joel Becker wrote: > On Thu, Nov 12, 2009 at 09:10:43AM +0100, Ingo Molnar wrote: > > 5 out of 8 places look buggy - i.e. more than 60% - a checkpatch warning > > would avoid real bugs here. (even ignoring the cleanliness effects of > > using proper error propagation) > > > > Cc:-ed affected maintainers. The rightmost column are my observations. > > Below is the patch fixing these. > > Acked-by: Joel Becker <joel.bec...@oracle.com>
I take that back. NAK. Sorry, I read the code wrong. This function is just a handler. The caller, dlm_send_begin_reco_message(), expects the positive EAGAIN as a non-error case. Joel -- Life's Little Instruction Book #337 "Reread your favorite book." Joel Becker Principal Software Developer Oracle E-mail: joel.bec...@oracle.com Phone: (650) 506-8127 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel