On Fri, Nov 13, 2009 at 08:53:06AM +0100, Ingo Molnar wrote:
> > Sorry, I read the code wrong. This function is just a handler. The
> > caller, dlm_send_begin_reco_message(), expects the positive EAGAIN as
> > a non-error case.
>
> Well, at minimum the error code usage is very confused. The
> dlm_begin_reco_handler gets registered via o2net_register_handler().
> Here's where dlm_begin_reco_handler gets registered, followed by
> dlm_finalize_reco_handler right afterwards:
<snip>
> A negative error code right there. The other event handlers are seem to
> be similar - dlm_begin_reco_handler() is the odd one out.
The usage of the handlers - 'status' is the return code of the
handler - is pretty straightforward. Once you're in the mindset of the
o2net code, of course. This is old stuff, from the earliest days of
ocfs2 development, so we haven't had to spelunk in here for a while ;-)
Sunil and I both thought while looking at this code that we
could probably return -EAGAIN just as easily, though. We'll probably
clean it that way at some point.
Joel
--
There are morethings in heaven and earth, Horatio,
Than are dreamt of in your philosophy.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.bec...@oracle.com
Phone: (650) 506-8127
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
