On Thu, Dec 10, 2009 at 08:51:07PM +0100, Thomas Hellstrom wrote: > Jerome Glisse wrote: > > Hi, > > > > So here is a patch which convert bo_init to use struct ttm_placement > > rather than flag. It allow the driver to give placement preference > > on where to create a bo. Also allow to create a bo at specific range > > which is i believe somethings nouveau would like to see :) > > > > Aside from the change i renamed ttm_buffer_object_init|validate to > > ttm_bo_init|validate this is shorter but also more consistent with > > others functions naming. For consistency i would like to rename > > struct ttm_buffer_object to struct ttm_bo but this lead to massive > > regular expression abuse for everyone using ttm so before proposing > > a patch let me know if you like or not this. I haven't strong > > feeling on that except that this would allow to stay in the 80 line > > lenght in some place. > > > > Cheers, > > Jerome > > > > > Jerome, this looks good and consistent with previous changes. > > In order to get the vmwgfx driver ready for upstream in the not too > distant future we need a (temporarily) stable API. Is this patch > targeted for 2.6.33? > > /Thomas >
I think i will do the massive rename for 2.6.34 so i am will be in charge of converting other driver, rather than putting any more burden on others driver. It's not very important it's just cleanup. Cheers. Jerome ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel