2010/3/12 Jerome Glisse <gli...@freedesktop.org>: > On Thu, Mar 11, 2010 at 05:24:22PM +0100, Rafał Miłecki wrote: >> 2010/3/11 Alex Deucher <alexdeuc...@gmail.com>: >> > I like keeping all the asic definitions in one file as you tend to >> > need to update them all at one time and having them spread across all >> > the asic files increases the likelihood of one or more of them getting >> > missed. But I can live with it if other folks think it's a good idea. >> >> Same here. One file means easier editing. Maybe we could use some >> other of proposed tricks? >> >> -- >> Rafał > > I don't have strong feeling but Alex has a point, right now we often > update them, maybe we should add radeon_asic.c and move asic init > (function now in radeon_device.c) along structure there. >
I've seen it sugggested earlier, Just don't use declarations in the C file, that isn't acceptable coding. If we add radeon_asic.h make sure to include that in places that define the functions as well. Last thing we want is declarations to diverge by accident. Dave. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
