On Fri, 2010-05-14 at 13:06 +0200, Dan Carpenter wrote: > Smatch complained that we initialize 6 elements in add_detailed_modes() > but the timings[] array is declared with 5 elements. Adam Jackson > verified that 6 is the correct number of timings. > > On Mon, May 10, 2010 at 12:08:24PM -0400, Adam Jackson wrote: > > > > struct std_timing timings[5]; > > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > This decl is wrong, should be 6. From the 1.4 spec: > > > > "Six additional Standard Timings may be listed as a display descriptor > > (tag #FAh)." > > > > The 1.3 spec is a little less explicit about it, but does show 6 > > standard timing codes in the 0xFA detailed subblock, terminated by 0x0A > > in the 18th byte. I don't have the docs for 1.2 or earlier, but we're > > paranoid enough about not adding broken timings that we should be fine. > > This patch is basically a clean up, because timings[] is declared inside > a union and increasing the number of elements here doesn't change the > overall size of the union. > > Signed-off-by: Dan Carpenter <erro...@gmail.com>
Reviewed-by: Adam Jackson <a...@redhat.com> - ajax
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
