----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22172/#review44660 -----------------------------------------------------------
contrib/native/client/src/clientlib/CMakeLists.txt <https://reviews.apache.org/r/22172/#comment79107> Trailing whitespaces. Plese merge with the latest patch for DRILL-875 contrib/native/client/src/clientlib/CMakeLists.txt <https://reviews.apache.org/r/22172/#comment79108> Include files in y2038 in the source as #include "y2038/foo.h" Also, build y2038 as a static lib and link the client lib with it. contrib/native/client/src/clientlib/recordBatch.cpp <https://reviews.apache.org/r/22172/#comment79109> #include "y2038/time64.h" is much clearer and cannot be mistaken for a system file contrib/native/client/src/include/drill/drillc.hpp <https://reviews.apache.org/r/22172/#comment79110> Nice catch :) contrib/native/client/src/include/drill/recordBatch.hpp <https://reviews.apache.org/r/22172/#comment79111> Indentation needs fixing - Parth Chandra On June 3, 2014, 6:24 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22172/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 6:24 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > We choose a third-party MIT-licensed library written with ANSI C > (https://github.com/schwern/y2038) to handle Y2038 problem due to the > limitation of the alternatives (standard library function gmtime and boost > date time library). > > > Diffs > ----- > > contrib/native/client/src/clientlib/recordBatch.cpp 066b898 > contrib/native/client/src/include/drill/drillc.hpp e5a0d33 > contrib/native/client/src/include/drill/recordBatch.hpp c40327b > > Diff: https://reviews.apache.org/r/22172/diff/ > > > Testing > ------- > > Test Query > > ./querySubmitter api=async type=sql > connectStr=jdbc:drill:local=localhost:31010 query="select cast('-123456-7-8' > as date) as negative_date, cast('876543-2-1' as date) as positive_date, > timestamptztype(-2038,1,2,3,4,5,6,'UTC') as tz from > INFORMATION_SCHEMA.SCHEMATA" > > > Thanks, > > Xiao Meng > >
