-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22172/
-----------------------------------------------------------
(Updated June 4, 2014, 12:12 a.m.)
Review request for drill.
Changes
-------
Handle the review comments and rebased on Parth's patch DRILL-875.
Bugs: DRILL-748
https://issues.apache.org/jira/browse/DRILL-748
Repository: drill-git
Description
-------
We choose a third-party MIT-licensed library written with ANSI C
(https://github.com/schwern/y2038) to handle Y2038 problem due to the
limitation of the alternatives (standard library function gmtime and boost date
time library).
Diffs (updated)
-----
LICENSE 98d9950
contrib/native/client/CMakeLists.txt a306780
contrib/native/client/src/clientlib/CMakeLists.txt d07f930
contrib/native/client/src/clientlib/recordBatch.cpp 066b898
contrib/native/client/src/clientlib/y2038/time64.h PRE-CREATION
contrib/native/client/src/clientlib/y2038/time64.c PRE-CREATION
contrib/native/client/src/clientlib/y2038/time64_config.h PRE-CREATION
contrib/native/client/src/clientlib/y2038/time64_limits.h PRE-CREATION
contrib/native/client/src/include/drill/drillc.hpp e5a0d33
contrib/native/client/src/include/drill/recordBatch.hpp c40327b
Diff: https://reviews.apache.org/r/22172/diff/
Testing
-------
Test Query
./querySubmitter api=async type=sql
connectStr=jdbc:drill:local=localhost:31010 query="select cast('-123456-7-8'
as date) as negative_date, cast('876543-2-1' as date) as positive_date,
timestamptztype(-2038,1,2,3,4,5,6,'UTC') as tz from INFORMATION_SCHEMA.SCHEMATA"
Thanks,
Xiao Meng
