> On June 6, 2014, 12:42 a.m., Aditya Kishore wrote: > > pom.xml, line 647 > > <https://reviews.apache.org/r/22283/diff/1/?file=604446#file604446line647> > > > > I did not mean it to be written it in exact this way. However, the end > > version string SHOULD look like > > "1.0.0-m2-incubating-SNAPSHOT", > > "1.0.0-m2-incubating-mapr-SNAPSHOT", > > "1.0.0-m2-incubating-cdh-SNAPSHOT", > > "1.0.0-m2-incubating-hdp-SNAPSHOT", > > etc. > >
I tried to use this plugin to do it safely: http://mojo.codehaus.org/build-helper-maven-plugin/parse-version-mojo.html However, it parses the version like this: - Major: 1 - Minor: 0 - Incremental: 0 - Qualifier: m2-incubating-SNAPSHOT - Build Number: 0 Therefore, the cleanest way this can be done by this method is: "1.0.0-m2-incubating-SNAPSHOT", "1.0.0-mapr-m2-incubating-SNAPSHOT", "1.0.0-cdh-m2-incubating-SNAPSHOT", "1.0.0-hdp-m2-incubating-SNAPSHOT", Although it is possible to use a regex to insert the profile string in between "incubating" and "SNAPSHOT", the whole "m2-incubating" string will eventually be removed. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22283/#review44872 ----------------------------------------------------------- On June 5, 2014, 11:32 p.m., Patrick Wong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22283/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 11:32 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-917 > https://issues.apache.org/jira/browse/DRILL-917 > > > Repository: drill-git > > > Description > ------- > > DRILL-917 - Different version string for each profile > > Parent POMs are untouched > > > Diffs > ----- > > common/pom.xml 55d4dd4 > contrib/data/tpch-sample-data/pom.xml ab968f2 > contrib/sqlline/pom.xml fb90134 > contrib/storage-hbase/pom.xml 09b4f0f > contrib/storage-hive/pom.xml 314e016 > distribution/pom.xml 6f8b3a9 > exec/bufferl/pom.xml a8e48ad > exec/java-exec/pom.xml 83220ab > exec/jdbc-all/pom.xml 55274ed > exec/jdbc/pom.xml afaaa6d > pom.xml eb31663 > protocol/pom.xml ca29ba9 > > Diff: https://reviews.apache.org/r/22283/diff/ > > > Testing > ------- > > > Thanks, > > Patrick Wong > >
