> On June 6, 2014, 12:26 a.m., Aditya Kishore wrote:
> > pom.xml, line 30
> > <https://reviews.apache.org/r/22283/diff/1/?file=604446#file604446line30>
> >
> > Why not use "${project.version}"?
I just tried this, and it breaks the subprojects. The string
"${project.version}" is preserved, and resolved separately for each subproject.
Since I had set most subprojects to have a version of "${drill.version}", it
gets into an infinite loop.
- Patrick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22283/#review44870
-----------------------------------------------------------
On June 5, 2014, 11:32 p.m., Patrick Wong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22283/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 11:32 p.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Bugs: DRILL-917
> https://issues.apache.org/jira/browse/DRILL-917
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-917 - Different version string for each profile
>
> Parent POMs are untouched
>
>
> Diffs
> -----
>
> common/pom.xml 55d4dd4
> contrib/data/tpch-sample-data/pom.xml ab968f2
> contrib/sqlline/pom.xml fb90134
> contrib/storage-hbase/pom.xml 09b4f0f
> contrib/storage-hive/pom.xml 314e016
> distribution/pom.xml 6f8b3a9
> exec/bufferl/pom.xml a8e48ad
> exec/java-exec/pom.xml 83220ab
> exec/jdbc-all/pom.xml 55274ed
> exec/jdbc/pom.xml afaaa6d
> pom.xml eb31663
> protocol/pom.xml ca29ba9
>
> Diff: https://reviews.apache.org/r/22283/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Patrick Wong
>
>
