-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22562/
-----------------------------------------------------------

Review request for drill, Jacques Nadeau and Parth Chandra.


Bugs: DRILL-836
    https://issues.apache.org/jira/browse/DRILL-836


Repository: drill-git


Description
-------

A new field 'support_complex_types' has been added to UserToBitHandshake 
messgae which is set to 'false' by default and is set to 'true' by Drill JDBC 
client.

The C/C++ client need not be modified or can set it to 'false' explicitly.

If this field is set to 'false', a new operator 'Flatten' will be added just 
below the 'Screen' operator which will convert all incoming complex type 
vectors to JSON encoded VARBINARY vector.


Diffs
-----

  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Flatten.java 
PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/FlattenBatchCreator.java
 PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
 93cd19d 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FlattenPrel.java
 PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FlattenPrelVisitor.java
 PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
 883b039 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java 
31bfd4e 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java 
3ee25d9 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 
6ecffaf 
  exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java ad114ab 
  
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java
 199ecfc 
  protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java 
c984876 
  protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 105281a 
  protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java d9f4c20 
  
protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java 
3690625 
  
protocol/src/main/java/org/apache/drill/exec/proto/beans/UserToBitHandshake.java
 70235b1 
  protocol/src/main/protobuf/User.proto ea12323 
  protocol/src/main/protobuf/UserBitShared.proto 4bafeb8 

Diff: https://reviews.apache.org/r/22562/diff/


Testing
-------

Ran the entire Unit Test suit with the option set to 'false' + manual testing 
with sqlline with HBase tables by temporarily setting it to false in Drill JDBC 
client.


Thanks,

Aditya Kishore

Reply via email to