-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22562/
-----------------------------------------------------------
(Updated June 13, 2014, 4:26 p.m.)
Review request for drill, Jacques Nadeau and Parth Chandra.
Changes
-------
+ With the new patch, we return VARCHAR instead of VARBINARY.
+ Added test case.
+ Minor code refactoring.
Bugs: DRILL-836
https://issues.apache.org/jira/browse/DRILL-836
Repository: drill-git
Description (updated)
-------
A new field 'support_complex_types' has been added to UserToBitHandshake
messgae which is set to 'false' by default and is set to 'true' by Drill JDBC
client.
The C/C++ client need not be modified or can set it to 'false' explicitly.
If this field is set to 'false', a new operator 'Flatten' will be added just
under the 'Screen' operator which will convert all incoming complex types to
JSON encoded VARCHAR type.
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java
PRE-CREATION
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/BaseHBaseTest.java
dbeced3
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/HBaseRecordReaderTest.java
1462b81
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/HBaseTestsSuite.java
a24215d
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseCFAsJSONString.java
PRE-CREATION
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java
2071e90
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseProjectPushDown.java
7037b9a
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
7dc7702
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionUtil.java
fbdab8e
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
51a7dbb
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Flatten.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/FlattenBatchCreator.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectBatchCreator.java
929071d
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
93cd19d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java
9b84724
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FlattenPrel.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FlattenPrelVisitor.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
883b039
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
2a3266a
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcException.java
9b5eb1d
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java
31bfd4e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
3ee25d9
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java
6ecffaf
exec/java-exec/src/main/java/org/apache/drill/exec/util/ConvertUtil.java
750885c
exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java
38cd530
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java ad114ab
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java
199ecfc
protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java
c984876
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 105281a
protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java d9f4c20
protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java
3690625
protocol/src/main/java/org/apache/drill/exec/proto/beans/UserToBitHandshake.java
70235b1
protocol/src/main/protobuf/User.proto ea12323
protocol/src/main/protobuf/UserBitShared.proto 4bafeb8
Diff: https://reviews.apache.org/r/22562/diff/
Testing
-------
Ran the entire Unit Test suit with the option set to 'false' + manual testing
with sqlline with HBase tables by temporarily setting it to false in Drill JDBC
client.
Thanks,
Aditya Kishore
