----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22474/#review45686 -----------------------------------------------------------
Could you add some tests? exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java <https://reviews.apache.org/r/22474/#comment80629> This logic seems very similar to the one in "ltrim" and "rtrim" functions. Do you think its possible to move that logic in StringFunctionUtil and use that in the three functions? - Mehant Baid On June 11, 2014, 9:07 p.m., Cliff Buchanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22474/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:07 p.m.) > > > Review request for drill. > > > Bugs: DRILL-561 > https://issues.apache.org/jira/browse/DRILL-561 > > > Repository: drill-git > > > Description > ------- > > * Created btrim by combining ltrim and rtrim. > * DrillOptiq turns trim to ltrim, rtrim, or btrim. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java > 51a7dbb > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java > 3576622 > > Diff: https://reviews.apache.org/r/22474/diff/ > > > Testing > ------- > > manually with sqlline. > > > Thanks, > > Cliff Buchanan > >
