----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22474/#review46878 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On June 27, 2014, 12:16 a.m., Cliff Buchanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22474/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 12:16 a.m.) > > > Review request for drill. > > > Bugs: DRILL-561 > https://issues.apache.org/jira/browse/DRILL-561 > > > Repository: drill-git > > > Description > ------- > > * Created btrim by combining ltrim and rtrim. > * DrillOptiq turns trim to ltrim, rtrim, or btrim. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionUtil.java > 844a3e8 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java > 33f2c94 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java > 21ff421 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestStringFunctions.java > af741a5 > exec/java-exec/src/test/resources/functions/string/testTrim.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/22474/diff/ > > > Testing > ------- > > * manually with sqlline. > * ran mvn test -Dtest=TestStringFunctions > > > Thanks, > > Cliff Buchanan > >
