----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22607/ -----------------------------------------------------------
(Updated July 3, 2014, 6:59 p.m.) Review request for drill and Mehant Baid. Changes ------- Implemented review comments. Merged patch for 524,706,988. Testcase: $mvn test -Dtest=TestNewMathFunctions#testTruncDivMod Repository: drill-git Description ------- Drill-988 - Trunc func injects a long cast which would cause loss of data Added BigDecimal for truncation and return type is same as passed params. Diffs (updated) ----- exec/java-exec/src/main/codegen/data/MathFunc.tdd b5b5543 exec/java-exec/src/main/codegen/templates/MathFunctions.java c4298fb exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java 3289601 exec/java-exec/src/test/resources/functions/testDivModTruncFunctions.json PRE-CREATION Diff: https://reviews.apache.org/r/22607/diff/ Testing ------- Via Sqlline Thanks, Yash Sharma
