----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22607/#review47685 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On July 8, 2014, 7:05 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22607/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 7:05 p.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Drill-988 - Trunc func injects a long cast which would cause loss of data > Added BigDecimal for truncation and return type is same as passed params. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/data/MathFunc.tdd b5b5543 > exec/java-exec/src/main/codegen/templates/MathFunctions.java c4298fb > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java > 3289601 > exec/java-exec/src/test/resources/functions/testDivModTruncFunctions.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/22607/diff/ > > > Testing > ------- > > Via Sqlline > > > Thanks, > > Yash Sharma > >
