> On Sept. 24, 2014, 1:26 a.m., Timothy Chen wrote: > > contrib/native/client/example/querySubmitter.cpp, line 27 > > <https://reviews.apache.org/r/25976/diff/1/?file=703975#file703975line27> > > > > What's the reasons to mix C and C++ styles here?
In general I follow the convention of using a struct over a class where the object simply holds data and has no behaviour (no methods other than setter/getter methods). - Parth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25976/#review54376 ----------------------------------------------------------- On Sept. 24, 2014, 1:24 a.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25976/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 1:24 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > C++ client library was sending an invalid Cancel response instead of a Cancel > request to the server > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 17bec3c > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > > Diff: https://reviews.apache.org/r/25976/diff/ > > > Testing > ------- > > Updated querySubmitter test program to send a cancel and tested both sync and > async apis > > > Thanks, > > Parth Chandra > >
