> On Sept. 29, 2014, 8:15 p.m., Xiao Meng wrote: > > contrib/native/client/src/clientlib/drillClientImpl.cpp, line 743 > > <https://reviews.apache.org/r/25976/diff/1/?file=703977#file703977line743> > > > > It seems that isOK is always true in the patch. Did we miss somthing?
No you didn't miss anything. The send ack message could send either true or false back to the server, but we are never actually sending a false. I put it in the method for some possible future use. - Parth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25976/#review54862 ----------------------------------------------------------- On Sept. 24, 2014, 1:24 a.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25976/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 1:24 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > C++ client library was sending an invalid Cancel response instead of a Cancel > request to the server > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 17bec3c > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > > Diff: https://reviews.apache.org/r/25976/diff/ > > > Testing > ------- > > Updated querySubmitter test program to send a cancel and tested both sync and > async apis > > > Thanks, > > Parth Chandra > >
