----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26672/#review56478 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26672/#comment96832> What does printf("%p %p \n", (void*)prevSchema, (void*)this->m_columnDefs); print? I would expect the two to be the same. So did this code really change anything? contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/26672/#comment96833> Did you just leak the column defs? - Parth Chandra On Oct. 14, 2014, 12:41 a.m., Norris Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26672/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 12:41 a.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > hasSchemaChanged is always set as true for all record batches except the > first one regardless of whether the schema has changed or not, including > cases where specific columns are projected, which should never happen. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.cpp 77795ed > > Diff: https://reviews.apache.org/r/26672/diff/ > > > Testing > ------- > > > Thanks, > > Norris Lee > >
