----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26672/ -----------------------------------------------------------
(Updated Oct. 15, 2014, 6:09 p.m.) Review request for drill and Parth Chandra. Changes ------- delete the FieldMetadata after the string/key is placed into the oldSchema map. Added a check to ignore empty data. Note that prevSchema is still not required. Steps: A key for each FieldMetadata in m_columnDefs is placed into oldSchema. FieldMetadata is deleted from m_columnDefs since it's no longer needed. New FieldMetadata is placed into m_columnDefs from pQueryResult, at this time it is also checked against oldSchema. Clean up oldSchema. By the end of this, m_columnDefs will contain items from the last batch, which will be cleared up by clearAndDestroy Repository: drill-git Description ------- hasSchemaChanged is always set as true for all record batches except the first one regardless of whether the schema has changed or not, including cases where specific columns are projected, which should never happen. Diffs (updated) ----- contrib/native/client/src/clientlib/drillClientImpl.cpp 77795ed Diff: https://reviews.apache.org/r/26672/diff/ Testing ------- Thanks, Norris Lee
