Oh, sorry, I forgot to ask: "should I need send the revert path for it"?
Thanks.
On 02/01/2014 02:11 PM, Chen Gang wrote:
> After check, for me, reverting is OK enough. I did not find issues of
> original implementation (related things look reasonable to me).
>
> Original implementation really needs re-factor (but it is not urgent).
> If we perform re-factor, for me, we need:
>
> - check all variables and parameters real using wide in this function.
> e.g.
> 'b', 'buf', 'remain' are global wide within this function.
> 'plen', 'ch' can be defined within 'while()'.
> 'dbuf', 'dlen' can be defined within 'case' (but broken by 'goto').
> ...
>
> - separate all easy (more independent) blocks to another functions.
> that will let the main code smaller (e.g from 1000 to 200 lines).
>
> - after simplifies all things, process 'goto' statement.
>
> And excuse me, I have no related environments to perform the test after
> re-factor, so welcome any other members to help re-factor and perform a
> test.
>
>
> Welcome any additional suggestions, discussions and completions.
>
> Thanks.
>
> On 01/25/2014 06:45 PM, Chen Gang wrote:
>> On 01/23/2014 11:16 PM, Dan Carpenter wrote:
>>> On Tue, Dec 10, 2013 at 01:05:46PM +0300, Dan Carpenter wrote:
>>>> On Tue, Dec 10, 2013 at 03:27:55PM +0530, Rashika Kheria wrote:
>>>>> Should I attempt to rectify the code in handle_data_in_packet() ?
>>>>
>>>> Yes, please.
>>>>
>>>
>>> What ever happened with this?
>>>
>>
>> Sorry, I don't known.
>>
>>> It sort of too late now and I think we should just revert b73db5475048
>>> ('Staging: dgrp: Refactor the function dgrp_receive() in
>>> drrp_net_ops.c')
>>>
>>
>> For me, it is necessary to revert firstly.
>>
>> I have started this 'Suggestion', so if still can not get response from
>> related members, I will/should process it (after revert it, I will
>> analyse it and try to provide a new fix for it).
>>
>> And really sorry, I have no enough time resources to focus on upstream
>> kernel in this month, so I plan to finish it within next month (2014-02-28).
>>
>>
>> BTW: my current related time resources are:
>>
>> 2014-01: make driver, user mode library, and Java demo under android.
>>
>> In Chinese Festival, I have time resource to upstream kernel and qemu.
>>
>> 2014-02: migrate diver, library, and develop an obj-C demo to iphone.
>>
>>
>> Thanks.
>>
>
>
--
Chen Gang
Open, share and attitude like air, water and life which God blessed
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
