Dan Carpenter <dan.carpen...@oracle.com> writes:
> On Wed, May 21, 2014 at 09:37:29AM +0200, jes.soren...@redhat.com wrote:
>> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
>> b/drivers/staging/rtl8723au/core/rtw_mlme.c
>> index b912d09..8c6b094 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_mlme.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
>> @@ -1027,9 +1027,8 @@ rtw_joinbss_update_stainfo(struct rtw_adapter
>> *padapter,
>> /* security related */
>> if (padapter->securitypriv.dot11AuthAlgrthm ==
>> dot11AuthAlgrthm_8021X) {
>> - padapter->securitypriv.binstallGrpkey = false;
>> - padapter->securitypriv.busetkipkey = false;
>> - padapter->securitypriv.bgrpkey_handshake = false;
>> + padapter->securitypriv.binstallGrpkey = 0;
>> + padapter->securitypriv.busetkipkey = 0;
>>
>
> You remove ->bgrpkey_handshake in this patch. That's fine because it
> is a write-only variable. But that's should be in a separate patch and
> described in the changelog next time.
Dan,
When cleaning up the mess of this driver, things happen. I can figure
out when to submit things and when not to.
If you find bugs, I certainly appreciate the reports but this is just
-ENITPICK.
Jes
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
