On Wed, May 27, 2015 at 05:56:27AM +0000, Gujulan Elango, Hari Prasath (H.) 
wrote:
> On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > On Tue, May 26, 2015 at 10:04:44AM +0000, Gujulan Elango, Hari Prasath (H.) 
> > wrote:
> > > replace kzalloc with devm_kzalloc thereby removing the corresponding
> > > kfree.
> > your patch is corrupt and can not be applied.
> > But even then, can this be called as code improvement?
> > 
> > regards
> > sudip
> > > 
> > > Signed-off-by: Hari Prasath Gujulan Elango <hguju...@visteon.com>
> > > ---
> 
> May i know whats wrong with the patch ? I am able to apply it without
> any issue.

ERROR: patch seems to be corrupt (line wrapped?)
#74: FILE: drivers/staging/sm750fb/sm750.c:1113:
        =20

WARNING: line over 80 characters
#76: FILE: drivers/staging/sm750fb/sm750.c:1114:
+       spec_share =3D devm_kzalloc(&pdev->dev, sizeof(*spec_share), 
GFP_KERNEL);

ERROR: spaces required around that '=' (ctx:WxV)
#76: FILE: drivers/staging/sm750fb/sm750.c:1114:
+       spec_share =3D devm_kzalloc(&pdev->dev, sizeof(*spec_share), 
GFP_KERNEL);


regards
sudip
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to