On Fri, Nov 25, 2016 at 03:31:09PM -0700, Jason Litzinger wrote:
> Fix checkpatch warnings regarding the use of symbolic permissions.
> 
> Where the MOST_CHANNEL_ATTR macro is used, convert to octal
> permissions over symbolic.
> 
> Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
> update the show/store function names appropriately.
> 
> Signed-off-by: Jason Litzinger <jlitzinger...@gmail.com>
> ---
> changelog:
> v2)  Fix missing semicolon on hunk with _ATTR_WO.
> 
> Tested/built/loaded linux-next(next-20161125)
> Test-built staging-next from staging tree

This is fine, but the fact that the most subsystem feels like it has to
have its own attribute type is the big problem with this file, that
should not be needed at all, and hopefully will be fixed up someday soon
(i.e. it's a requirement before it can get out of staging...)

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to