Hi Petr,

Petr Machata <pe...@mellanox.com> writes:

> A driver might need to react to changes in settings of brentry VLANs.
> Therefore send switchdev port notifications for these as well. Reuse
> SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use
> netif_is_bridge_master() on orig_dev to determine whether the
> notification is about a bridge port or a bridge.
>
> Signed-off-by: Petr Machata <pe...@mellanox.com>

> +     } else {
> +             err = br_switchdev_port_obj_add(dev, v->vid, flags);
> +             if (err && err != -EOPNOTSUPP)
> +                     goto out;
>       }

Except that br_switchdev_port_obj_add taking vid and flags arguments
seems confusing to me, the change looks good:

Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>

Thanks,

        Vivien
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to